Skip to content

refactor: remove redundant IsInSlots wrapper in favor of slices.Contains #15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

refactor: remove redundant IsInSlots wrapper in favor of slices.Contains #15890

wants to merge 3 commits into from

Conversation

maximevtush
Copy link

Summary

Removes the unnecessary IsInSlots wrapper function that was just calling slices.Contains with swapped arguments.

Changes

  • Removed IsInSlots function from container/slice/slice.go
  • Updated usage in testing/endtoend/evaluators/slashing.go to use slices.Contains directly
  • Updated tests in container/slice/slice_test.go to test slices.Contains instead of the wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maximevtush